fix(dts): gracefully shutdown when panic #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeless0911
force-pushed
the
disconnect
branch
from
0bb96d6 to
4e542fa
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds graceful shutdown handling for the DTS generation child process when the parent process panics or terminates unexpectedly. By listening to the disconnect event, the child process can exit cleanly instead of hanging or producing excessive error output.
Key Changes
- Added a
disconnectevent handler to exit the child process when IPC channel is disconnected - Improves error output clarity when the parent process crashes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenjiahan
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gracefully shutdown when main process panic.
Before
Now
Related Links
Checklist