docs: remove HomeBackground and navTransparent hack #1344
Merged
+15
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
Timeless0911
November 18, 2025 06:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a workaround by eliminating the custom HomeBackground wrapper component that was used to achieve a transparent navigation bar at the top of the home page. The simplification is made possible by upgrading @rstack-dev/doc-ui from version 1.11.0 to 1.12.0, which likely provides the necessary background functionality natively.
- Removed the
HomeBackgroundwrapper component and associated transparent nav hack - Upgraded
@rstack-dev/doc-uipackage to version 1.12.0 - Simplified the home page layout to use
BackgroundImagedirectly
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/theme/pages/index.tsx | Removed HomeBackground wrapper component and unused import; simplified HomeLayout to directly use BackgroundImage |
| website/package.json | Upgraded @rstack-dev/doc-ui from 1.11.0 to 1.12.0 |
| pnpm-lock.yaml | Updated lock file with new package versions and transitive dependencies (framer-motion 12.23.24, motion-dom 12.23.23) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove HomeBackground and navTransparent hack.
Related Links
web-infra-dev/rsbuild#6601
Checklist