fix: should only make entry doppelganger in non-advanced ESM #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeless0911
previously approved these changes
Nov 19, 2025
fi3ework
force-pushed
the
sssaaflsdfas
branch
from
0132f7f to
8113dd3
Compare
Copilot finished reviewing on behalf of
fi3ework
November 19, 2025 11:59
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the entry chunk plugin to only apply to formats that actually need it - specifically non-advanced ESM and IIFE formats that use the modern-module library type.
- Restricts the entry loader to only activate for
esmandiifeformats whenadvancedEsmis not enabled - Removes the plugin from CJS, UMD, and MF formats where it's not needed
- Updates test snapshots to reflect the removal of the plugin from non-applicable formats
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Added format check (format === 'esm' || format === 'iife') to the useLoader condition to restrict entry chunk plugin to only applicable formats |
| packages/core/tests/snapshots/config.test.ts.snap | Updated snapshots to remove rsbuild:lib-entry-chunk plugin entries from CJS, UMD, and MF format test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
force-pushed
the
sssaaflsdfas
branch
from
8113dd3 to
fdcf410
Compare
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Timeless0911
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
only non-advancedEsm
modern-moduleneed this, as others formats doesn't rely on it.Related Links
Checklist