test: refactor dts tests to split into multiple test files #1364
+1,017
−991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
Timeless0911
November 25, 2025 08:15
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the DTS (TypeScript Declaration) integration tests by splitting a large monolithic test file (~944 lines) into multiple smaller, feature-focused test files for better organization and maintainability.
Key Changes
- Split
tests/integration/dts/index.test.tsinto 6 separate test files organized by DTS mode (bundle, bundle-false, build, composite, check, other-features) - Updated fixture paths in test files to be relative to their new locations using
__dirname - Reorganized snapshot files to match the new test file structure
- Moved the
copytest fixture toother-featuressubdirectory and updated related paths
Reviewed changes
Copilot reviewed 12 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/dts/index.test.ts | Deleted 944-line monolithic test file |
| tests/integration/dts/bundle/index.test.ts | New test file for bundle mode tests (266 lines) |
| tests/integration/dts/bundle-false/index.test.ts | New test file for bundle-false mode tests (240 lines) |
| tests/integration/dts/build/index.test.ts | New test file for build mode tests (219 lines) |
| tests/integration/dts/composite/index.test.ts | New test file for composite mode tests (194 lines) |
| tests/integration/dts/check/index.test.ts | New test file for tsconfig validation tests (30 lines) |
| tests/integration/dts/other-features/index.test.ts | New test file for output.copy feature test (20 lines) |
| tests/integration/dts/other-features/copy/* | Moved copy test fixtures to other-features subdirectory |
| tests/integration/dts/*/snapshots/index.test.ts.snap | Created/updated snapshot files for new test structure |
| tests/integration/dts-tsgo/*/index.test.ts | Fixed fixture paths by removing redundant directory names |
| pnpm-lock.yaml | Updated path reference for copy fixture |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refactor dts tests to split into multiple test files
Related Links
Checklist