New Contact Picker feature #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
approved these changes
Jul 5, 2024
Collaborator
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I agree with your decision to pin this to Chrome Android 80.
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Collaborator
|
CI is failing due to #1331. I'll fix it up here and suggest how we should fix it more generally in that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reality is that the API landed without a way to get addresses, in Chrome for Android 80. Then addresses were added, and landed in Chrome for Android 84 (https://chromestatus.com/feature/6316401599971328).
I decided to list all BCD keys in just one feature, and use
compute_fromto stick the status to version 80.We could, instead:
Either move the address stuff into a later addition feature.
I don't think this is necessary seeing how the two things landed at around the same general timeframe, and this timeframe is long past.
Or remove
compute_fromand make the overall feature start with 84.This would make it disagree with what's written at the bottom of https://developer.mozilla.org/en-US/docs/Web/API/Contact_Picker_API