Override async clipboard status awaiting fix in BCD #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
This was referenced Jul 10, 2024
ddbeck
approved these changes
Jul 10, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
This is fine, though we're now reporting Firefox as supporting while caniuse doesn't (I think because of the no-longer clipboard-read permission). I saw on mdn/browser-compat-data#23593 that you've got some permissions follow ups anyway. Do you need to file an issue on caniuse for this too?
Collaborator
Author
|
I've sent Fyrd/caniuse#7106 to align Chromium versions, and will file an issue about Firefox. I'll link to everything in a new comment before landing. |
The manually added status is what will result from treating all 4 methods on navigator.clipboard as required parts of the feature. Comment out read() and readText() to not bless the incorrect status computed from BCD. Fixes web-platform-dx#1249.
foolip
force-pushed
the
clipboard-override
branch
from
64fb0ee to
2939e18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manually added status is what will result from treating all 4
methods on navigator.clipboard as required parts of the feature.
Comment out read() and readText() to not bless the incorrect status
computed from BCD.
Fixes #1249.