Skip to content

Don't write a spec draft with an empty compat_features array #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Don't write a spec draft with an empty compat_features array #1357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/update-drafts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ async function main() {
}
}

// Separate out features that are already part of web-features.
for (const [spec, compatFeatures] of specToCompatFeatures.entries()) {
// Separate out features that are already part of web-features.
const usedFeatures = new Map<string, Set<String>>();
for (const key of compatFeatures) {
if (webFeatures.has(key)) {
Expand All @@ -103,6 +103,11 @@ async function main() {
}
}

// If all features are already part of web-features, skip this spec.
if (compatFeatures.size === 0) {
continue;
}

// Write out draft feature per spec.
const id = formatIdentifier(spec.shortname);

Expand Down