Skip to content

Uncomment keys and compute_from (features A-C) #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Uncomment keys and compute_from (features A-C) #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b61e67
Uncomment keys and compute_from (A-C)
ddbeck Jul 16, 2024
81296e3
Reinstate aysnc-clipboard commentary
ddbeck Jul 16, 2024
e322f9f
Merge branch 'main' into uncomment-a-c
ddbeck Jul 19, 2024
9d97766
Refresh dist
ddbeck Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions features/accelerometer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Accelerometer
description: The `Accelerometer` and `LinearAccelerationSensor` APIs read the acceleration applied to a device in three dimensions, either including the effect of gravity or not, respectively.
spec: https://w3c.github.io/accelerometer/#accelerometer-interface
group: sensors
status:
compute_from: api.Accelerometer.Accelerometer
compat_features:
- api.Accelerometer
- api.Accelerometer.Accelerometer
Expand All @@ -11,5 +13,4 @@ compat_features:
- api.LinearAccelerationSensor
- api.LinearAccelerationSensor.LinearAccelerationSensor
- api.Permissions.permission_accelerometer
# Later addition
# - http.headers.Permissions-Policy.accelerometer
- http.headers.Permissions-Policy.accelerometer
7 changes: 7 additions & 0 deletions features/accelerometer.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,10 @@ compat_features:
- api.Accelerometer.z
- api.LinearAccelerationSensor
- api.LinearAccelerationSensor.LinearAccelerationSensor

# baseline: false
# support:
# chrome: "88"
# chrome_android: "88"
# edge: "88"
- http.headers.Permissions-Policy.accelerometer
7 changes: 4 additions & 3 deletions features/async-clipboard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ caniuse: async-clipboard
# https://github.com/Fyrd/caniuse/pull/7106
# https://github.com/Fyrd/caniuse/issues/7107
group: clipboard
# This feature's support history and data has been rather tangled. See:
# https://github.com/web-platform-dx/web-features/issues/1249
status:
baseline: low
baseline_low_date: 2024-06-11
Expand All @@ -20,9 +22,8 @@ status:
safari_ios: "13.4"
compat_features:
- api.Clipboard
# TODO: include after https://github.com/mdn/browser-compat-data/pull/23593
Copy link
Contributor

@captainbrosset captainbrosset Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling we should keep this comments, and others like it. There's some good research in there, which I would hate to lose.

Copy link
Collaborator Author

@ddbeck ddbeck Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that. In the interest of consolidating all of untangling of this feature, I've updated and linked to #1249 with 81296e3.

# - api.Clipboard.read
# - api.Clipboard.readText
- api.Clipboard.read
- api.Clipboard.readText
- api.Clipboard.write
- api.Clipboard.writeText
- api.ClipboardItem
Expand Down
13 changes: 13 additions & 0 deletions features/async-clipboard.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,18 @@ compat_features:
- api.Clipboard.writeText
- api.Navigator.clipboard

# baseline: low
# baseline_low_date: 2024-04-16
# support:
# chrome: "66"
# chrome_android: "66"
# edge: "79"
# firefox: "125"
# firefox_android: "125"
# safari: "13.1"
# safari_ios: "13.4"
- api.Clipboard.readText

# ⬇️ Same status as overall feature ⬇️
# baseline: low
# baseline_low_date: 2024-06-11
Expand All @@ -28,6 +40,7 @@ compat_features:
# firefox_android: "127"
# safari: "13.1"
# safari_ios: "13.4"
- api.Clipboard.read
- api.Clipboard.write

# baseline: low
Expand Down
7 changes: 3 additions & 4 deletions features/constructed-stylesheets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ description: The `CSSStyleSheet` constructor creates a new stylesheet which can
spec:
- https://drafts.csswg.org/cssom-1/#dom-cssstylesheet-cssstylesheet
- https://drafts.csswg.org/cssom-1/#dom-documentorshadowroot-adoptedstylesheets
status:
compute_from: api.CSSStyleSheet.CSSStyleSheet
compat_features:
- api.CSSStyleSheet.CSSStyleSheet
- api.CSSStyleSheet.replace
- api.CSSStyleSheet.replaceSync
- api.Document.adoptedStyleSheets
- api.ShadowRoot.adoptedStyleSheets
# Setting the base URL is probably not important for typical uses of
Copy link
Contributor

@captainbrosset captainbrosset Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, and elsewhere. It would be nice if we had a way to keep these editorial notes in there somewhere, maybe in a more structured form.
It would be nice to see them in the dist files in fact.What do you think?

Copy link
Collaborator Author

@ddbeck ddbeck Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we had a way to keep these editorial notes in there somewhere, maybe in a more structured form.

I agree that it would be nice, though I think compute_from is going to handle the most common case, by marking the boundary after which things are later additions. So I'm doubtful that every comment saying "this is a later addition" will make sense to maintain.

Moreover, a lot of compat_features lists will eventually live as tags in BCD. So we'd need a separate way to list compat key commentary. I think we'd need some whole new way to annotate keys not directly referenced in authored YAML files. I'd be open to that, but I also don't have any ideas about what that would look like. Do you want to file an issue about this?

And in the meantime, do you want me to preserve this comment specifically?

It would be nice to see them in the dist files in fact.

This is the one bit I'm not especially keen on. We used to do just that and it meant that every single change to a feature YAML required a refresh. People didn't like it! 😄

Copy link
Contributor

@captainbrosset captainbrosset Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that just having a comment that says "later addition" isn't useful. I'm more concerned about the various links and pieces of info that we spent time digging up when researching a feature.

# constructed stylesheets (it doesn't appear in examples) and should be
# treated as a later minor addition to the feature.
# - api.CSSStyleSheet.CSSStyleSheet.options_baseURL_parameter
- api.CSSStyleSheet.CSSStyleSheet.options_baseURL_parameter
19 changes: 19 additions & 0 deletions features/constructed-stylesheets.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,27 @@ status:
safari: "16.4"
safari_ios: "16.4"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: low
# baseline_low_date: 2023-03-27
# support:
# chrome: "73"
# chrome_android: "73"
# edge: "79"
# firefox: "101"
# firefox_android: "101"
# safari: "16.4"
# safari_ios: "16.4"
- api.CSSStyleSheet.CSSStyleSheet
- api.CSSStyleSheet.replace
- api.CSSStyleSheet.replaceSync
- api.Document.adoptedStyleSheets
- api.ShadowRoot.adoptedStyleSheets

# baseline: false
# support:
# firefox: "101"
# firefox_android: "101"
# safari: "16.4"
# safari_ios: "16.4"
- api.CSSStyleSheet.CSSStyleSheet.options_baseURL_parameter
12 changes: 6 additions & 6 deletions features/counter-style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: "@counter-style"
description: The `@counter-style` CSS at-rule defines custom counter styles for list items. For example, you can use a sequence of specific symbols instead of numbers for an ordered list.
spec: https://drafts.csswg.org/css-counter-styles-3/
caniuse: css-at-counter-style
status:
compute_from: css.at-rules.counter-style
compat_features:
- css.at-rules.counter-style
- css.at-rules.counter-style.additive-symbols
Expand All @@ -22,9 +24,7 @@ compat_features:
- api.CSSCounterStyleRule.range
- api.CSSCounterStyleRule.system
- api.CSSCounterStyleRule.suffix
# Partial support except in Safari:
# - css.at-rules.counter-style.symbols
# - api.CSSCounterStyleRule.symbols
# Firefox only:
# - css.at-rules.counter-style.speak-as
# - api.CSSCounterStyleRule.speakAs
- css.at-rules.counter-style.symbols
- api.CSSCounterStyleRule.symbols
- css.at-rules.counter-style.speak-as
- api.CSSCounterStyleRule.speakAs
25 changes: 25 additions & 0 deletions features/counter-style.yml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@ status:
safari: "17"
safari_ios: "17"
compat_features:
# ⬇️ Same status as overall feature ⬇️
# baseline: low
# baseline_low_date: 2023-09-18
# support:
# chrome: "91"
# chrome_android: "91"
# edge: "91"
# firefox: "33"
# firefox_android: "33"
# safari: "17"
# safari_ios: "17"
- api.CSSCounterStyleRule
- api.CSSCounterStyleRule.additiveSymbols
- api.CSSCounterStyleRule.fallback
Expand All @@ -21,7 +32,9 @@ compat_features:
- api.CSSCounterStyleRule.pad
- api.CSSCounterStyleRule.prefix
- api.CSSCounterStyleRule.range
- api.CSSCounterStyleRule.speakAs
- api.CSSCounterStyleRule.suffix
- api.CSSCounterStyleRule.symbols
Comment on lines +35 to +37
Copy link
Collaborator Author

@ddbeck ddbeck Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by far the weirdest bit. I don't know if we should be troubled by properties for unsupported descriptors, but it's at least true (it made me stop to check that these are indeed on CSSCounterStyleRule.prototype).

Copy link
Collaborator

@foolip foolip Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's surprising that this has been exposed in CSSOM in both Chrome and Firefox if they don't actually work. But if that's true, I think they ought to be partial_implementation in BCD. I think it'd be best to not include the keys until this is investigated.

Copy link
Collaborator Author

@ddbeck ddbeck Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at this more closely.

For symbols, the CSSOM story is accurate: the CSSOM exposure works in Firefox and Chrome, but the descriptor is only partially implemented. Implementers other than Safari don't support <image> values, and this seems to be correct.

For speak-as, I've sent mdn/browser-compat-data#23857.

We can wait on the latter PR, or I can comment out the key until it lands. Do you have a preference (and maybe we should turn that preference into a policy)?

Copy link
Collaborator

@foolip foolip Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think waiting for BCD slows us down and we need a policy that allows us to think about these things once. And the risk to minimize is the risk that whatever we assume will happen doesn't happen, and we never notice we got it wrong.

I think these won't be Baseline anyway, so OK to just proceed,

- api.CSSCounterStyleRule.system
- css.at-rules.counter-style
- css.at-rules.counter-style.additive-symbols
Expand All @@ -32,3 +45,15 @@ compat_features:
- css.at-rules.counter-style.range
- css.at-rules.counter-style.suffix
- css.at-rules.counter-style.system

# baseline: false
# support:
# safari: "17"
# safari_ios: "17"
- css.at-rules.counter-style.symbols

# baseline: false
# support:
# firefox: "33"
# firefox_android: "33"
- css.at-rules.counter-style.speak-as