Skip to content

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Jul 16, 2024

Since we use tsx to run scripts, there's no explicit type checking .ts files outside of compute-baseline. Nevertheless, my editor shows type errors at editing time.

This PR makes two changes to fix this:

  • Adds a test:types npm run command and includes it in the test command
  • Fixes the (thankfully few) type errors reported.

@foolip foolip merged commit 4857918 into web-platform-dx:main Jul 17, 2024
@ddbeck ddbeck deleted the typecheck branch July 18, 2024 12:27
petele pushed a commit to petele/web-features that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants