Skip to content

Conversation

@petele
Copy link
Contributor

@petele petele commented Jul 16, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 16, 2024
petele and others added 2 commits July 17, 2024 10:27
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Comment on lines 22 to 23
# Excluded because of a non-real value
# - api.TextTrack.inBandMetadataTrackDispatchType
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip - I think this is the right thing here, according to MDN this is supported, but it has a limited value. If I don't comment out the line, the whole feature is not baseline because that is apparently not supported in Chrome.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does npm run dist throw an error if you include it? By non-real value we mean things like true in BCD that we can't handle and throw an error. I agree with excluding it, just want to understand.

To not have to fine tune the comment, you can just delete the lines. This whole block will go away if we move the tags to BCD.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it does not throw an error.

Looking a bit deeper, this property it's not supported by Chrome, and there's no plan to support it.

I uncommented that line, and used compute_from, but I don't think that's the right answer either. Open to suggestions here. @ddbeck @captainbrosset

@petele petele requested a review from foolip July 17, 2024 14:37
@foolip
Copy link
Collaborator

foolip commented Jul 18, 2024

@petele can you also rename the file to text-tracks.yml in line with audio-video-tracks.yml?

petele and others added 2 commits July 18, 2024 11:26
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@foolip foolip merged commit 9b60d67 into web-platform-dx:main Jul 18, 2024
@petele petele deleted the elem-track branch July 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants