-
Notifications
You must be signed in to change notification settings - Fork 199
Add <track> element
#1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <track> element
#1443
Conversation
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
features/track.yml
Outdated
| # Excluded because of a non-real value | ||
| # - api.TextTrack.inBandMetadataTrackDispatchType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does npm run dist throw an error if you include it? By non-real value we mean things like true in BCD that we can't handle and throw an error. I agree with excluding it, just want to understand.
To not have to fine tune the comment, you can just delete the lines. This whole block will go away if we move the tags to BCD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it does not throw an error.
Looking a bit deeper, this property it's not supported by Chrome, and there's no plan to support it.
I uncommented that line, and used compute_from, but I don't think that's the right answer either. Open to suggestions here. @ddbeck @captainbrosset
|
@petele can you also rename the file to |
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
No description provided.