JS Self-Profiling API #1458
Merged
JS Self-Profiling API #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
foolip
reviewed
Jul 18, 2024
Collaborator
|
Oops, I had comments on this in two tabs and the comments from one were lost. Rewriting... |
foolip
reviewed
Jul 18, 2024
ddbeck
reviewed
Jul 29, 2024
Collaborator
|
Hey @captainbrosset, this has some suggestions and needs some conflicts resolved, when you have time for it. |
Contributor
Author
|
@ddbeck I went with the name "Profiler", to match the ID, and because "Self profiling" felt like an odd name to me. We don't know what developers will call this API in the future, using the constructor's name feels like a safer starting point. |
ddbeck
requested changes
Aug 21, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
requested changes
Aug 22, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Contributor
Author
|
Changed description to remove script/javascript (since API is slated to support more than this over time). |
ddbeck
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.