-
Notifications
You must be signed in to change notification settings - Fork 201
Add WebGL2 Canvas Context #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,6 @@ | |||
| name: WebGL2 Color Space | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to splitting this into two features, one has baseline low, the other is only supported in Chrome/Edge.
It also has the same support versions as the same functionality in WebGL1, so we could alternatively merge it that way.
| @@ -0,0 +1,5 @@ | |||
| name: WebGL2 `desynchronized` parameter | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has same support as WebGL1 desynchronized so we could merge these two. I feel like WebGL1/WebGL2 are very different and keeping them separate makes sense. But can be convinced otherwise.
| @@ -0,0 +1,6 @@ | |||
| name: WebGL2 drawing buffer | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has same support as WebGL1 drawingBufferXXX so we could merge these two. I feel like WebGL1/WebGL2 are very different and keeping them separate makes sense. But can be convinced otherwise.
| @@ -0,0 +1,5 @@ | |||
| name: WebGL2 `powerPreference` parameter | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has similar support as WebGL1 powerPreference, with Safari being significantly different (10.1/3 vs 15). We could merge these two, but based on the significant difference, I'd lean towards no.
| - api.WebGL2RenderingContext.vertexAttribPointer | ||
| - api.WebGL2RenderingContext.viewport | ||
| - api.WebGL2RenderingContext.waitSync | ||
| - api.WebGLQuery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though this is titled WebGLXXX it is explicitly WebGL2... Same for some of the other top level APIs
|
Replaced by #1584 |
I did not use
compute_from, since it's alreadyhigh.