Skip to content

Upload GitHub release artifacts on tag push #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

Upload GitHub release artifacts on tag push #1559

merged 1 commit into from
Aug 8, 2024

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Aug 8, 2024 •
edited
Loading

Part of #938.

@foolip foolip requested a review from ddbeck August 8, 2024 13:07
@foolip
Copy link
Collaborator Author

foolip commented Aug 8, 2024

I iterated on this in my fork until I got it to work, and here's the proof:
https://github.com/foolip/web-features/actions/runs/10302679214/job/28516952064
https://github.com/foolip/web-features/releases/tag/v99.99.101

This was referenced Aug 8, 2024
Merged
Closed
ddbeck
ddbeck approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding, thank you!

@ddbeck ddbeck merged commit 8677a39 into web-platform-dx:main Aug 8, 2024
@foolip foolip deleted the upload-release-artifacts branch August 8, 2024 15:07
@ddbeck ddbeck mentioned this pull request Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@foolip @ddbeck