Add WeakMap and WeakSet #1563
Merged
Add WeakMap and WeakSet #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Aug 19, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I think these features look fine, but I'm less certain about my proposed descriptions. @Elchi3 as resident JS docs expert, would you like to have a look at my suggestions? (If you don't want to, that's fine too—I can apply my suggestions and merge instead.)
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Elchi3
reviewed
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.