Add RegExp methods #1565
Merged
Add RegExp methods #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Aug 12, 2024
features/regexp.yml
Outdated
| - javascript.builtins.RegExp.@@replace | ||
| - javascript.builtins.RegExp.@@search | ||
| - javascript.builtins.RegExp.@@species | ||
| - javascript.builtins.RegExp.@@split |
Collaborator
There was a problem hiding this comment.
We also need javascript.grammar.regular_expression_literals and all of the non-deprecated javascript.regular_expressions.* keys. It's possible there are some distinct features in there, but it'll be easier to pick them out with the dist file.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Contributor
Author
|
Added additional keys, and removed all deprecated functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a handful of deprecated methods that I've included, but think we should probably remove? Looking for confirmation please.
compileinputlastMatchlastParentleftContextrightContext