-
Notifications
You must be signed in to change notification settings - Fork 199
Add String methods #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add String methods #1566
Conversation
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on the Intl discussion elsewhere, I'm suggesting dropping the Intl-related methods in line comments.
Also: @Elchi3, you and I talked about this (and Number and some others). I think you rightly pointed out that at least some string methods ought to have their own features (e.g., at()), for symmetry with the Array features. Should we pull that stuff out now? Or would it make more sense to split it up in a separate PR after merging?
I think I would pull that out now and possibly figure out in this PR what we want the "String (initial support)" feature to be here (analog to features/array.yml). |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
|
Based on feedback, and to somewhat mirror |
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a number of changes, mostly to names and descriptions. I didn't apply them because a few file renames are needed. Thank you!
Also, @Elchi3, optionally if you want to give this a once-over to compare to the Array features, I'd appreciate it.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work 👍
No description provided.