Skip to content

Make the spec draft updater remove completed specs and work around nulls #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Make the spec draft updater remove completed specs and work around nulls #1571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/update_draft_features_weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ jobs:
node-version-file: .node-version
cache: npm
- run: npm ci
- run: rm features/draft/spec/*.yml features/draft/spec/*.dist
- run: npm run update-drafts
- run: npm run dist
- name: Commit changes
run: |
git config --local user.email "action@github.com"
Expand Down
7 changes: 7 additions & 0 deletions scripts/update-drafts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ async function main() {
continue;
}

// A few null values remain in BCD. They are being removed in
// https://github.com/mdn/browser-compat-data/pull/23774.
// TODO: Remove this workaround when BCD is free or true/null values.
if (feature.id.startsWith("html.manifest.")) {
continue;
}

const spec_url = feature.data.__compat.spec_url;
if (!spec_url) {
continue;
Expand Down