Skip to content

Conversation

@ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Aug 16, 2024

Fixes #1600

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 16, 2024
@petele
Copy link
Contributor

petele commented Aug 16, 2024

I tried adding Prettier to VSCode, and it didn't report a warning I expected, but it was reported when running npm test.

Repro steps:
Put 2 spaces after description:.

Expect: ✅ Error in VS Code reporting extra space, ✅ npm run test reports warning
Actual: ❌ No error in VS Code, ✅ npm run test reports warning

@ddbeck
Copy link
Collaborator Author

ddbeck commented Aug 16, 2024

@petele I don't think the Prettier VS Code extension gives warnings. I think it's only a formatter. You can invoke it via the Command Palette "Format Document" or (my recommendation) turn on the editor.formatOnSave preference. I also suggest turning on the prettier.requireConfig setting so it doesn't start running everywhere, unbidden.

@ddbeck ddbeck merged commit e7a0883 into web-platform-dx:main Aug 21, 2024
@ddbeck ddbeck deleted the prettier-tip branch August 21, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dist doesn't catch errors that test does

3 participants