Skip to content

Make dist errors and warnings more explicit about fixes #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Make dist errors and warnings more explicit about fixes #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/dist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ function toDist(sourcePath: string): YAML.Document {
source.compat_features.sort();
if (isDeepStrictEqual(source.compat_features, taggedCompatFeatures)) {
logger.warn(
`${id}: compat_features override matches tags in @mdn/browser-compat-data. Consider deleting this override.`,
`${id}: compat_features override matches tags in @mdn/browser-compat-data. Consider deleting the compat_features override.`,
);
}
}
Expand Down Expand Up @@ -211,7 +211,7 @@ function toDist(sourcePath: string): YAML.Document {
if (source.status) {
if (isDeepStrictEqual(source.status, computedStatus)) {
logger.warn(
`${id}: status override matches computed status. Consider deleting this override.`,
`${id}: status override matches computed status. Consider deleting the status override.`,
);
}
}
Expand All @@ -236,7 +236,7 @@ function toDist(sourcePath: string): YAML.Document {
if (computeFromWasExplicitlySet) {
if (groups.size === 1) {
logger.error(
`${id}: uses compute_from which must not be used when the overall status does not differ from the per-key statuses. Delete this override.`,
`${id}: uses compute_from which must not be used when the overall status does not differ from the per-key statuses. Delete the status override.`,
);
exitStatus = 1;
}
Expand Down