Add catch for invalid spec URLs #1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
previously approved these changes
Aug 21, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Oh excellent, thank you!
ddbeck
dismissed
their stale review
oh wait no it turned out I was not finished 🤦♂️
ddbeck
requested changes
Aug 21, 2024
ddbeck
added
the
tools and infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a missing or invalid spec URL would throw an error without a message. This change surfaces that error when running
npm run test:specs.In addition, the test was reporting the number of specs as the number of features, so now it reports both.