Skip to content

Conversation

@autonome
Copy link
Contributor

@autonome autonome commented Aug 21, 2024

  • confirmed not already in progress
  • moved files
  • updated filename if needed (eg remove "TC39-" or s/webdriver2/webdriver/)
  • removed draft date
  • determined name
  • added description (triangulated from mdn, spec, caniuse)
  • added entry point
  • verified baselines
  • checked api list against mdn list
  • added to a group or not
  • determined whether the feature should be split
  • looked for other related draft features that could be included
  • what else?

Resources

Filename

Philip did the synth part already and named it speech-synthesis.yml.

The remaining bits are the SpeechGrammar and SpeechRecognition APIs, so i'll split this up into three files for now, along the speech-*.yml pattern.

Name

Again, will follow the pattern already started w/ the synth api.

Group

There's already separate groups made, which seems odd. Feels like if we're coalescing 14k pieces of web platform surface area into 2-3k features, all of this would be the Web Speech API, which is how developers, spec authors and MDN all seem to think about it. But Philip kicked this one off and is one of the spec authors so, I'll leave it as is for now.

Splits/Merges

See above, I suspect we group this into a single feature later.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 21, 2024
@autonome
Copy link
Contributor Author

@ddbeck any idea why SpeechGrammar is in BCD but not mapping here?

@ddbeck
Copy link
Collaborator

ddbeck commented Aug 29, 2024

@ddbeck any idea why SpeechGrammar is in BCD but not mapping here?

I'm sorry, but I'm not 100% sure what this means. Are you asking why the computed status is unsupported but the compat data shows some kind of support (e.g., https://developer.mozilla.org/en-US/docs/Web/API/SpeechGrammar#browser_compatibility) it's because of prefixes and runtime flags, which don't count toward a Baseline status.

@autonome
Copy link
Contributor Author

autonome commented Sep 2, 2024

bah, i had commands that searched features/draft/spec but not features/draft so missed the file there.

PR on hold indefinitely, if/when speech apis get unprefixed.

@ddbeck
Copy link
Collaborator

ddbeck commented Sep 3, 2024

It's OK to have features that aren't Baseline in the feature set (we just need to make sure that it makes sense when we do!), if you still want to move ahead on this.

@autonome autonome marked this pull request as ready for review September 4, 2024 10:31
@autonome autonome marked this pull request as draft September 4, 2024 10:32
@autonome autonome marked this pull request as ready for review September 4, 2024 13:23
@autonome
Copy link
Contributor Author

autonome commented Sep 4, 2024

Ok, i think this is ready now. SpeechGrammar is all prefixed everywhere , looks like.

Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review, overall looks good!

autonome and others added 5 commits September 5, 2024 11:00
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
@autonome
Copy link
Contributor Author

autonome commented Sep 5, 2024

Thanks for review @jamesnw, fixes made, ready for @ddbeck

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting pretty close. One big suggestion (merging a feature) and some nits.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ddbeck ddbeck merged commit b0cda19 into web-platform-dx:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants