-
Notifications
You must be signed in to change notification settings - Fork 199
Add speech API #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speech API #1636
Conversation
|
@ddbeck any idea why SpeechGrammar is in BCD but not mapping here? |
I'm sorry, but I'm not 100% sure what this means. Are you asking why the computed status is unsupported but the compat data shows some kind of support (e.g., https://developer.mozilla.org/en-US/docs/Web/API/SpeechGrammar#browser_compatibility) it's because of prefixes and runtime flags, which don't count toward a Baseline status. |
|
bah, i had commands that searched PR on hold indefinitely, if/when speech apis get unprefixed. |
|
It's OK to have features that aren't Baseline in the feature set (we just need to make sure that it makes sense when we do!), if you still want to move ahead on this. |
|
Ok, i think this is ready now. |
jamesnw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-review, overall looks good!
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting pretty close. One big suggestion (merging a feature) and some nits.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Resources
Filename
Philip did the synth part already and named it
speech-synthesis.yml.The remaining bits are the
SpeechGrammarandSpeechRecognitionAPIs, so i'll split this up into three files for now, along thespeech-*.ymlpattern.Name
Again, will follow the pattern already started w/ the synth api.
Group
There's already separate groups made, which seems odd. Feels like if we're coalescing 14k pieces of web platform surface area into 2-3k features, all of this would be the
Web Speech API, which is how developers, spec authors and MDN all seem to think about it. But Philip kicked this one off and is one of the spec authors so, I'll leave it as is for now.Splits/Merges
See above, I suspect we group this into a single feature later.