Add weak references #1654
Merged
Add weak references #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Sep 3, 2024
Comment on lines
+7
to
+14
| compat_features: | ||
| - javascript.builtins.FinalizationRegistry | ||
| - javascript.builtins.FinalizationRegistry.FinalizationRegistry | ||
| - javascript.builtins.FinalizationRegistry.register | ||
| - javascript.builtins.FinalizationRegistry.unregister | ||
| - javascript.builtins.WeakRef | ||
| - javascript.builtins.WeakRef.WeakRef | ||
| - javascript.builtins.WeakRef.deref |
Collaborator
There was a problem hiding this comment.
For the record, I wasn't 100% sure these needed to be together at first, but the original proposal illustrates their combined application, which convinced me: https://github.com/tc39/proposal-weakrefs?tab=readme-ov-file#using-weakref-objects-and-finalizationregistry-objects-together.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/tc39/proposal-weakrefs
https://chromestatus.com/feature/5892186633666560
https://v8.dev/features/weak-references
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakRef
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry