Skip to content

Conversation

@Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

https://github.com/tc39/proposal-iterator-helpers
https://chromestatus.com/feature/5102502917177344
https://v8.dev/features/iterator-helpers

Named "Iterator methods" for consistency with https://github.com/web-platform-dx/web-features/blob/main/features/set-methods.yml but happy to name it "Iterator helpers" ("helpers" feels quite generic, though). Also, I listed all the additions in the description just like we did with "Set methods".

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
Copy link
Contributor

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review.

Agree that "helpers" sounds generic, even though it's named that in the spec. Maybe worth digging around to see how developers refer to them, if you haven't already. But a convention around "methods" sounds good to me, as it's likely to come up again, and also naming is a balance of the status quo and what might make things better/easier for webdevs.

spec: https://tc39.es/proposal-iterator-helpers/
group: iterators
compat_features:
- javascript.builtins.Iterator.Iterator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for posterity: I wondered by javascript.builtins.Iterator wasn't included here. Ultimately, I found that it makes sense: BCD tells a half-truth in that all browsers support Iterator in the sense that they implement iterators. But don't actually expose Iterator as a defined object, at least not until they ship Iterator(). The BCD and MDN docs are extremely confusing on this point.

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@ddbeck ddbeck merged commit 3788042 into web-platform-dx:main Sep 17, 2024
@Elchi3 Elchi3 deleted the iterator-helpers branch September 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants