Add Async generators #1665
Merged
Add Async generators #1665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
approved these changes
Sep 4, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
Pre-review. Only non-blocking suggestions.
| @@ -0,0 +1,17 @@ | |||
| name: Async generators | |||
| description: Async generator functions (`async function*`) are asynchronous and always yield `Promise` objects. | |||
| group: javascript | |||
Collaborator
There was a problem hiding this comment.
Would it make sense to have a generators group?
Collaborator
Author
There was a problem hiding this comment.
Let me add that as a follow up when this PR and #1664 have been merged
Collaborator
There was a problem hiding this comment.
These are both merged now. 👍
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
ddbeck
reviewed
Sep 16, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function*