-
Notifications
You must be signed in to change notification settings - Fork 203
Add Functions #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Functions #1671
Conversation
|
Re filename - it opens the prefixing question, eg JS vs CSS functions. If we don't prefix one, we'll have to prefix the other, so in that case maybe should prefix both? |
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like this! I kept trying to nit pick some of the compat keys and then convincing myself you had it right. Nice work! Just a little wordsmithing to do here.
@autonome I'm not sure this will be a problem. CSS doesn't (yet 😬) have custom functions (and it'll probably be known as "custom functions" if/when it does), only predefined functions that slot into neat groups (e.g., transforms). |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
|
Should we merge this? |
|
Yes, let's merge. Patrick, if you have more suggestions for the description, please open a follow-up PR. Cheers! |
I've used compute_from to ignore some late-additions which are also all baseline high already.