Skip to content

Conversation

@Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Aug 26, 2024

I've used compute_from to ignore some late-additions which are also all baseline high already.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 26, 2024
@autonome
Copy link
Contributor

autonome commented Sep 2, 2024

Re filename - it opens the prefixing question, eg JS vs CSS functions. If we don't prefix one, we'll have to prefix the other, so in that case maybe should prefix both?

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this! I kept trying to nit pick some of the compat keys and then convincing myself you had it right. Nice work! Just a little wordsmithing to do here.

@ddbeck
Copy link
Collaborator

ddbeck commented Sep 3, 2024

If we don't prefix one, we'll have to prefix the other, so in that case maybe should prefix both?

@autonome I'm not sure this will be a problem. CSS doesn't (yet 😬) have custom functions (and it'll probably be known as "custom functions" if/when it does), only predefined functions that slot into neat groups (e.g., transforms).

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3
Copy link
Collaborator Author

Elchi3 commented Sep 12, 2024

Should we merge this?

@ddbeck
Copy link
Collaborator

ddbeck commented Sep 12, 2024

Yes, let's merge. Patrick, if you have more suggestions for the description, please open a follow-up PR. Cheers!

@ddbeck ddbeck merged commit 85618fd into web-platform-dx:main Sep 12, 2024
@Elchi3 Elchi3 deleted the functions branch September 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants