Skip to content

Conversation

@autonome
Copy link
Contributor

@autonome autonome commented Aug 27, 2024

  • reviewed prior work, or confirmed not already in progress
  • moved files
  • updated filename if needed (eg remove "TC39-" or s/webdriver2/webdriver/)
  • removed draft date
  • determined name
  • added description (triangulated from mdn, spec, caniuse)
  • added entry point
  • verified baselines
  • checked api list against mdn list
  • added to a group or not
  • determined whether the feature should be split
  • looked for other related draft features that could be included
  • what else?

See also

#960 and #973

@autonome autonome marked this pull request as draft August 27, 2024 14:08
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Aug 27, 2024
@autonome
Copy link
Contributor Author

Wrote up the feature composition proposal here: #973 (comment)

We can consider a group once we get to push notifications.

@autonome autonome marked this pull request as ready for review September 19, 2024 10:15
@ddbeck
Copy link
Collaborator

ddbeck commented Sep 20, 2024

I had a look at this and ended up poring over everything to do with notifications. It's very messy—primarily because caniuse describes this feature in a peculiar way—so we need to tread carefully as long as we're setting the caniuse key on this feature. See #973 (comment) for a much, much more detailed take.

@autonome autonome marked this pull request as draft September 25, 2024 07:47
@autonome autonome marked this pull request as draft October 15, 2024 12:06
autonome and others added 7 commits October 15, 2024 08:07
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
@autonome
Copy link
Contributor Author

Re-requested review from @captainbrosset for the description shortening in notifications-apps.yml.

@autonome
Copy link
Contributor Author

This now has the BCD changes from mdn/browser-compat-data#24705 and implements the approach recommended in #973.

@autonome autonome marked this pull request as ready for review November 29, 2024 13:24
autonome and others added 5 commits December 16, 2024 23:22
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@autonome autonome requested a review from ddbeck December 16, 2024 16:30
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Thank you @autonome and @captainbrosset for making this happen—a ton of work, but a huge improvement to the BCD and really exercising what we can do feature construction. 👏

@ddbeck ddbeck merged commit 990e27e into web-platform-dx:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants