-
Notifications
You must be signed in to change notification settings - Fork 199
Add Notifications API #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notifications API #1678
Conversation
|
Wrote up the feature composition proposal here: #973 (comment) We can consider a group once we get to push notifications. |
|
I had a look at this and ended up poring over everything to do with notifications. It's very messy—primarily because caniuse describes this feature in a peculiar way—so we need to tread carefully as long as we're setting the |
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
|
Re-requested review from @captainbrosset for the description shortening in |
|
This now has the BCD changes from mdn/browser-compat-data#24705 and implements the approach recommended in #973. |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! Thank you @autonome and @captainbrosset for making this happen—a ton of work, but a huge improvement to the BCD and really exercising what we can do feature construction. 👏
See also
#960 and #973