-
Notifications
You must be signed in to change notification settings - Fork 199
Add filter argument to update-drafts script #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
09cb3ec
Add filter argument to update-drafts script
jamesnw 928b896
Format
jamesnw 138e2c8
Merge branch 'main' of github.com:web-platform-dx/web-features into u…
jamesnw 13ff871
Add keys and paths filter to update-drafts
jamesnw 84ff469
Merge branch 'main' of github.com:web-platform-dx/web-features into u…
jamesnw 5d253b5
Allow paths AND keys
jamesnw df76801
Merge branch 'main' of github.com:web-platform-dx/web-features into u…
jamesnw 9dcb567
Fix bug
jamesnw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So CLIs are always more complicated than I imagine. 😅
This behaves very strangely if both options are set. I think it's applying both filters, such that nothing gets to match? I'm not sure.
I think the right thing to do here is to make sure the options don't layer on top of each other (or set some kind of flag like
--matches=id,--matches=path, and then all positional arguments must be one type). But this is starting to get complicated and holding up useful work.How about this: would you like to revert the changes after my review, add a
# TODO:linking back here and one of us can take that up in a follow up PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a simple change to make it an AND- for instance,
npx tsx scripts/update-drafts.ts --keys css --paths features/draft/spec/ba*will update all CSS specs ANDbadging.ymlandbattery-status.yml.If this doesn't seem correct, I'll revert and TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there! See my comment below.