Add calc.color_component to relative-color #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Sep 2, 2024
features/relative-color.yml
Outdated
| # Seemingly incorrect notes, see | ||
| # https://github.com/mdn/browser-compat-data/pull/22960 | ||
| # - css.types.color.rgb.relative_syntax | ||
| - css.types.calc.color_component |
Collaborator
There was a problem hiding this comment.
If you look above this, there are a bunch of comments and links to BCD issues. This feature also predates compute_from. It's a mess.
Maybe we should add color_component as a comment, then in a follow up PR figure out the status of each of the linked issues, an uncomment/update/compute_from as appropriate. What do you think?
Collaborator
Author
There was a problem hiding this comment.
Sounds good- I added a comment, commented this out, and will tackle this next!
ddbeck
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in BCD,
css.types.calc.color_componentis tagged asweb-features:calc. It should be included inrelative-colorinstead.