-
Notifications
You must be signed in to change notification settings - Fork 200
Add paint-order #1696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add paint-order #1696
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7140647
Add paint-order
jamesnw d5e4ee0
Merge branch 'main' of github.com:web-platform-dx/web-features into p…
jamesnw 0c5db52
Accept review
jamesnw 8987a17
Merge branch 'main' into paint-order
jamesnw 2f8b685
Update features/paint-order.yml
jamesnw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| name: paint-order | ||
| description: "The `paint-order` CSS property sets the z-order of strokes, fills, and (in SVG content) markers. For example, `paint-order: markers stroke fill;` draws the markers, then stroke on top of markers, then fill on top of both markers and stroke." | ||
| spec: https://svgwg.org/svg2-draft/painting.html#PaintOrder | ||
| group: css | ||
| compat_features: | ||
| - css.properties.paint-order | ||
| - svg.global_attributes.paint-order | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Generated from: paint-order.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: | ||
| chrome: "123" | ||
| chrome_android: "123" | ||
| edge: "123" | ||
| firefox: ≤66 | ||
| firefox_android: "66" | ||
| safari: ≤12 | ||
| compat_features: | ||
| # baseline: low | ||
| # baseline_low_date: 2024-03-22 | ||
| # support: | ||
| # chrome: "123" | ||
| # chrome_android: "123" | ||
| # edge: "123" | ||
| # firefox: "60" | ||
| # firefox_android: "60" | ||
| # safari: "11" | ||
| # safari_ios: "11" | ||
| - css.properties.paint-order | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: ≤73 | ||
| # chrome_android: "73" | ||
| # edge: ≤79 | ||
| # firefox: ≤66 | ||
| # firefox_android: "66" | ||
| # safari: ≤12 | ||
| - svg.global_attributes.paint-order |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably ought to have asked for this previously, but there's no time like the present: are SVG attributes part of their corresponding CSS properties? I'm not sure that's quite right, but it's not wrong either. I think there's two ways to handle this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's pretty helpful for authors to associate the SVG and CSS versions of a feature like this. They really are the same feature - similar to JS API's being included along side CSS. But I expect in most cases SVG support will be significantly broader/farther back, since these generally start in SVG and then get adopted into CSS. Ideally, if they're not together, they are at least clearly associated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, cool. This works for me. I've had a bit of a look around and it does seem common for SVG and CSS to mentioned in the same setting—let's keep these together. If we want to group the SVG stuff, we can do that later.