Remove long-animation-frames.yaml #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
approved these changes
Sep 5, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
uh oh, this is from long time ago and dist files weren't even a thing then. I think removing is fine, I'm happy to work on a proper feature for this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this file and believe it is there by accident. Renaming it to
.ymland running dist does not add any keys, so the tag doesn't appear to exist in BCD. Because it is a .yaml file, it is not included in data.json.It was originally added in #645. @Elchi3 is there a reason this file should be kept?