Add JSON features #1741
Merged
Add JSON features #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Sep 9, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
A few suggestions, but I like the overall shape of this.
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
captainbrosset
previously requested changes
Sep 10, 2024
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
ddbeck
approved these changes
Sep 12, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
One optional suggestion, but this seems basically done now?
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json: uses compute_from and also contains two later additions that are already baseline high these days so, I think we want tot treat them as "merged" into the main JSON featurejson-raw: JSON source text access, not baseline yet, new features from https://tc39.es/proposal-json-parse-with-source.jsonfor all things JSON (added JSON import attributes to this, too)