Add Payment Request and Payment Handler #1743
Conversation
github-actions
bot
added
the
feature definition
autonome
left a comment
autonome
left a comment
There was a problem hiding this comment.
Pre-review pass, looks good! I suggested some text changes to align with the guidelines, and also some opinionated suggestions to accept or not as you prefer.
Co-authored-by: Dietrich Ayala <50103+autonome@users.noreply.github.com>
|
Some additional keys that might be interesting here (search for "payment" in BCD): api.Permissions.permission_payment-handler |
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
@queengooborg can you add the above keys? (and check BCD if there are other "payment" keys)
features/payment-handler.yml
Outdated
| - api.ServiceWorkerGlobalScope.canmakepayment_event | ||
| - api.ServiceWorkerGlobalScope.paymentrequest_event | ||
| - api.ServiceWorkerRegistration.paymentManager | ||
| - http.headers.Permissions-Policy.payment |
There was a problem hiding this comment.
I think this belongs to Payment Request not Payment handler https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy/payment
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I think it'd be nice to finally merge this. That said, there are some issues with the names and descriptions. Since I think all of the participants on this are on holiday or out sick, I'm going to apply my own changes and merge. If there's any additional feedback or corrections needed here, please open a follow up pull request. Thank you!
Co-authored-by: Dietrich Ayala <50103+autonome@users.noreply.github.com> Co-authored-by: Florian Scholz <fs@florianscholz.com> Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
4 participants
This PR adds both the Payment Request and Payment Handler APIs as features for Baseline. Both of these APIs are related to merchant transactions, so I figured they would make sense to be added together.