Skip to content

Update checkVisibility #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2024
Merged

Update checkVisibility #1750

merged 5 commits into from
Sep 12, 2024

Conversation

@autonome
Copy link
Contributor

@autonome autonome commented Sep 9, 2024 •
edited
Loading

  • added some missing properties
  • added compute_from so that baseline low versions are correct for the core feature

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Sep 9, 2024
@autonome autonome changed the title Update checkVisibility with missing properties Update checkVisibility Sep 9, 2024
@autonome autonome marked this pull request as ready for review September 9, 2024 12:02
jamesnw
jamesnw approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review- this change looks good to me. I confirmed it's not on caniuse, and that there aren't other related keys.

@ddbeck ddbeck merged commit 7763fb6 into web-platform-dx:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddbeck ddbeck ddbeck approved these changes

@jamesnw jamesnw jamesnw approved these changes

Assignees

No one assigned

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@autonome @ddbeck @jamesnw