Remove unused release script code #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
added
the
tools and infrastructure
Elchi3
approved these changes
Sep 12, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Agreed, let's only bring this back if we need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused code from a previous (and premature) attempt to automate the release process.
For #1769, I tried using
scripts/release.ts, which was incomplete and predates our current release process, documented inpublishing.md.It kinda works—I want to open a PR to fix what's broken—but there's also a lot of unused code that I don't foresee using, at least not in the same way. Some it might return in some form later, but I think deleting this unusued/untested procedure in favor of incrementally automating the documented process is a better path forward.