-
Notifications
You must be signed in to change notification settings - Fork 199
Add Storage APIs #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storage APIs #1773
Conversation
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes, but I'd be interested in seeing this developed more concretely. Being somewhat unfamiliar with anything outside of window.localStorage, names and descriptions will go a long way to understanding how these things fit together.
|
Oh one more thought: if you want to start the group on the existing features now, before landing the new features, that would probably get merged quickly. |
|
Ok integrated earlier review comments, simplified overall approach and took out |
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
|
Ok I think all review comments addressed, just figure out a way forward for |
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
captainbrosset
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because I think this is the right way to create those features. But, please take a look at my remaining comments.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
|
Addressed all review comments but GH still showing blocked for some reason, so removing @ddbeck review to unblock merging, can follow up w/ any remaining issues afterward. Thanks everyone for helping w/ this one! |
Caniuse:
Web Storage - name/value pairsat 97% which points to the storage specStorageat 95% which also points to the storage specMDN
Storage APIand points at the various flavoursWeb Storage APIandStorageinterface (local/session storage)Shared StorageIndexedDBCookiesCache APIWeb Features
Storage bucketsfrom Add Storage buckets group #555Storage accessfrom Add storage access API #1032Storageglobals andStorageManager(but not the storage implementations)requestStorageAccessForAPIStorageimplementation globals and their APIsPlan:
Ignore Cookie and Cache APIs for now. Start w/ the Storage interface and its implementations, as that'll set the direction and be reference point for storage approaches that followed it. Add the "late additions" and recent privacy storage bits as separate features. The rest is mostly non-controversial standalone features. Add a group called "storage" and put everything in it.
Storage API- implementations of theStorageinterface and their globals, and includesStorage managerShared storageShared storage access for non-cookie storage(late addition, explicit difference)storageNot addessed: