Adds margin, padding #1781
Merged
Adds margin, padding #1781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
approved these changes
Sep 13, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
I confirmed no caniuse features, and no auto keywords in BCD for padding. 🚀
captainbrosset
approved these changes
Sep 27, 2024
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
Some minor comments on descriptions, looks good to me otherwise.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
ddbeck
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds features from
css-box-4: