Add border, border-radius and outline #1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
requested changes
Sep 24, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
I have some thoughts on outlines, but I like the rest of this as it is.
| name: border-radius | ||
| description: The `border-radius` CSS property rounds the corners of the border drawn around an element. | ||
| spec: https://drafts.csswg.org/css-backgrounds-3/#corners | ||
| caniuse: border-radius |
Collaborator
There was a problem hiding this comment.
Let's compute_from: css.properties.border-radius to better align with caniuse.
features/outlines.yml
Outdated
Comment on lines
2
to
6
| description: The `outline` CSS property sets the color, style, and width of a line around an element, outside of the border. The `outline-offset` CSS property sets the distance from the element's edge to the outline. | ||
| spec: https://drafts.csswg.org/css-ui-4/#outline | ||
| status: | ||
| # The `outline` shorthand was introduced at a later date. | ||
| compute_from: css.properties.outline-style |
Collaborator
There was a problem hiding this comment.
I think it's a bit weird for us to name outline as the entry point to this feature, yet say that it's supported before the thing we name in the description exists. I think we have three options here (in order of my uninformed feeling about it):
compute_fromon the constituent properties (outline-color,-offset, etc.) and change the description to match.- Break out
outlineinto its own feature. - Drop the
compute_fromand say that outlines are a recent feature.
FWIW I think caniuse was actually right here and BCD is wrong about outline. Filed this bug to correct BCD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caniuse for outline was just a bit too far off, with none of the features lining up with what I am seeing there.