Adds additional compat keys to page-breaks and column-breaks #1802
Conversation
github-actions
bot
added
the
feature definition
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
I think if we were creating these new features here, I would recommend pinning baseline to something, as most of the feature is usable. But I would recommend not changing the support status at all, which will be the case after the non-spec keys are removed.
features/page-breaks.yml.dist
Outdated
| chrome: "50" | ||
| chrome_android: "50" | ||
| edge: "12" | ||
| chrome: ≤80 | ||
| chrome_android: "80" | ||
| edge: ≤80 | ||
| firefox: "92" | ||
| firefox_android: "92" | ||
| safari: ≤13.1 | ||
| safari_ios: ≤13.4 |
There was a problem hiding this comment.
Unfortunately, this is going to be a little messy to align to caniuse's css-page-break. See #331 (comment) for background on how this pair of features came to be.
What needs to happen now: pick a compute_from that aligns us to caniuse. It's so messy, so I won't expect version-perfect results here, but we need to report that Chrome and Edge support this, while Safari and Firefox don't. I think this means pinning to avoid values, but I'm not 100% sure.
There was a problem hiding this comment.
This also provides more context: Fyrd/caniuse#7045
There was a problem hiding this comment.
Updated to compute from css.properties.page-break-after.avoid which appears to be the closest match
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
One request for a comment before merging this. Thank you!
3 participants
No description provided.