-
Notifications
You must be signed in to change notification settings - Fork 203
Adds multi-column layout #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adds multi-column layout #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
captainbrosset
approved these changes
Sep 20, 2024
This was referenced Sep 30, 2024
Merged
ddbeck
reviewed
Sep 30, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Oct 9, 2024
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vwallen If you merge main into the branch and refresh the dist here, this will merge cleanly. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following
gridandflexbox, groups the setup properties (column-count,column-width) with the rendering properties (column-gap,column-rule) together into a single feature called "Multi-column Layout" which aligns with how these features show up in posts/documentation. Thealign-contentproperty follows previous features that include it with the context in which it applies.Splits out
column-fillandcolumn-spaninto their own features because they apply to the content rather than the layout structure of the columns and/or they are properties of the child elements rather than the parent with the columns declaration.Adds
multi-columngroup