Contributor docs: write up merge practices #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
While the governance doc covers some _rules_, it doesn't catch some of our unwritten conventions. I've written this up in anticipation of adding new peers.
ddbeck
force-pushed
the
reviewers-guide
branch
from
30bc2f4 to
a41c3fe
Compare
jamesnw
approved these changes
Sep 24, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
Thanks for writing this up! It's very helpful.
docs/reviewing.md
Outdated
| If a pull request has been approved and tests are passing, then you can merge it. | ||
| Follow these steps to merge: | ||
|
|
||
| 1. Make sure **you** can merge this pull request. |
Collaborator
There was a problem hiding this comment.
A suggested addition-
1. Make sure you **should** merge this pull request.
In general, only merge pull requests you are already familiar with, either as an author or reviewer. 
Co-authored-by: James Stuckey Weber <jamesnw@gmail.com>
Co-authored-by: James Stuckey Weber <james@oddbird.net>
captainbrosset
approved these changes
Sep 25, 2024
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
A few non-blocking comments.
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
Alex666oguH
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the governance doc covers some rules, it doesn't catch some of our unwritten conventions. I've written this up in anticipation of adding new peers.