Add console as a feature #1839
Merged
Add console as a feature #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
captainbrosset
requested changes
Sep 25, 2024
Co-authored-by: Patrick Brosset <patrickbrosset@gmail.com>
captainbrosset
approved these changes
Sep 28, 2024
Contributor
captainbrosset
left a comment
captainbrosset
left a comment
There was a problem hiding this comment.
I think this is good to merge as is, but we need to do something about profile/profileEnd, I'd suggest opening a BCD issue to investigate if the Firefox support data needs to be updated.
Collaborator
|
I opened mdn/browser-compat-data#24675 |
Elchi3
approved these changes
Oct 9, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
I think this one is good without profile/profileEnd.
(I'm generally not sure what we want to do with non-standard BCD keys, but let's merge this for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the console interface as a feature.