Add Magnetometer API #1848
Merged
Add Magnetometer API #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
autonome
previously requested changes
Sep 26, 2024
ddbeck
requested changes
Sep 27, 2024
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Elchi3
approved these changes
Oct 10, 2024
Collaborator
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Looking at the other features with the "sensors" group, I think this is good to land for now.
Collaborator
|
I'd still prefer to have something done about #1848 (comment) but I won't stand in the way of merging, if no one else cares. |
Collaborator
|
@queengooborg do you want to return to this? #1848 (comment) is the last bit outstanding here. |
Contributor
Author
|
I think that the issue that was opened (#2299) is what is needed as a reminder to come back to this feature. I can add a comment, but I don't think it's necessary and this PR is ready to merge as-is. |
Elchi3
reviewed
Dec 12, 2024
ddbeck
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for the Magnetometer API.