Print destination path on feature init #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools and infrastructure
ddbeck
approved these changes
Sep 30, 2024
Collaborator
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
One optional suggestion for you. Feel free to merge with or without it.
scripts/feature-init.ts
Outdated
| process.exit(0); | ||
| } | ||
| await fs.writeFile(destination, formatted); | ||
| console.log(`Wrote ${destination}`); |
Collaborator
There was a problem hiding this comment.
If you write out just the file name, then it's possible to do something like this: my-editor $(npm run --silent feature-int -- …) or pipe it to another command, right?
Suggested change
| console.log(`Wrote ${destination}`); | |
| console.log(destination); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny QOL change- the first thing I want to do after running
feature-initis open the newly generated file. This prints the path to the console, so I can click on it and open it.