New Selection API features #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
captainbrosset
commented
Oct 2, 2024
captainbrosset
commented
Oct 2, 2024
Contributor
Author
There was a problem hiding this comment.
I couldn't name this just selection.yml, because that's already taken by the ::selection pseudo.
Contributor
There was a problem hiding this comment.
Matches both the spec title and the Caniuse key, so seems fine to me to keep API here, and there's precedent for doing so.
jamesnw
approved these changes
Oct 4, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
A few nits, but overall looks good!
Co-authored-by: James Stuckey Weber <james@oddbird.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Selection API has been evolving over the years, so I've spent some time here making the data match caniuse as best I could.
I think the support data makes sense.
I also really wanted to split out
getComposedRangesbecause this is much newer, and Chromium is working on an implementation currently, and it unlocks a developer use case that was previously impossible.