Skip to content

Conversation

@jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Oct 2, 2024

There are some odd parts to this-

text-wrap-style: balance has less support than text-wrap: balance.

text-wrap: wrap is in the text-wrap: nowrap feature, and text-wrap-mode: nowrap is in the text-wrap-mode feature. Maybe those should get sorted differently?

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 2, 2024
@autonome
Copy link
Contributor

autonome commented Oct 4, 2024

Looks like is missing some dist files?

@jamesnw
Copy link
Collaborator Author

jamesnw commented Oct 4, 2024

Looks like is missing some dist files?

No- the files without dists in the diff are ones where I just changed the groups, so there were no changes to the dist.

@autonome
Copy link
Contributor

autonome commented Oct 5, 2024

text-wrap-style: balance has less support than text-wrap: balance.

looks like doesn't impact status though?

text-wrap: wrap is in the text-wrap: nowrap feature,

Yeah, this is counterintuitive. Seems like wrap would be a better feature, with nowrap in it, if we had to choose.

and text-wrap-mode: nowrap is in the text-wrap-mode feature. Maybe those should get sorted differently?

CSS seems full of these mode switchers and shorthands... if having the wrap mode standalone w/ variable values aligns w/ how you've been handling these so far, then this seems fine?

@jamesnw
Copy link
Collaborator Author

jamesnw commented Oct 7, 2024

text-wrap-style: balance has less support than text-wrap: balance.

looks like doesn't impact status though?

It does- text-wrap-style: balance is baseline: false, since it doesn't have Chrome support.

I ended up re-sorting the keys, and created a text-wrap-style feature, and made it more of a support-based feature set.

@jamesnw jamesnw requested a review from autonome October 7, 2024 17:28
@autonome autonome merged commit 68ae1c5 into web-platform-dx:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants