Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hrm, I just saw the deprecated keys conversation in chat, and it seems like this feature should've given a warning or failure? Maybe I didn't see it, if just a warning.Here we've got a non-deprecated interface where the implementation key is deprecated.MDN doesn't mention deprecation, just recommends using other approaches.Caniuse highlights the deprecation in the window implementation, but not for the interface.Ok, just a sub-key is deprecated. Neither the interface or implementation are.Will include it, commented out, with an explanation.Edit again again:
And I think that's seems right. Using this feature in the modern way is not baseline at this time.
Having a better explicit way to park deprecations would be good to figure out.