Skip to content

Conversation

@jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Oct 3, 2024

speak-as is a weird property. What has wide-ish support and any sort of documentation is speak-as inside an @counter-style rule to describe how markers in a list should be read, and that is part of the @counter-style feature.

This feature is NOT that. This feature applies to any element, and confusingly has a different set of valid properties. Should I disambiguate here somehow?

@autonome - I added this to the speech group, but the name of that group is "Web Speech API". Could that group be broadened to include these hints for the speech synthesis? I think just renaming it "Speech" would suffice.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 3, 2024
@autonome
Copy link
Contributor

autonome commented Oct 4, 2024

This feature is NOT that. This feature applies to any element, and confusingly has a different set of valid properties. Should I disambiguate here somehow?

If this feature is truly distinct from the speak-as inside a @counter-style, then is worth adding a comment in the yml file. I haven't seen us making this kind of disambiguation inside descriptions, which aim to be standalone.

@autonome - I added this to the speech group, but the name of that group is "Web Speech API". Could that group be broadened to include these hints for the speech synthesis? I think just renaming it "Speech" would suffice.

Sounds good to me. I am all for making groups generally useful as a discovery mechanism, whether for WF contributors or developers generally, and this would achieve that for either audience.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion for the description, to handle the point of confusion you noted. Free to merge with or without the suggestion though.

jamesnw and others added 2 commits October 9, 2024 13:34
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@jamesnw jamesnw enabled auto-merge (squash) October 9, 2024 17:35
@jamesnw jamesnw merged commit 1217c8e into web-platform-dx:main Oct 9, 2024
3 checks passed
@jamesnw jamesnw deleted the speak-as branch October 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants