Skip to content

Conversation

@vwallen
Copy link
Contributor

@vwallen vwallen commented Oct 7, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 7, 2024
Copy link
Contributor

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James is better for review of feature composition here, but early feedback on the group is that should remove -css and instead make this a child of the css group, see example: https://github.com/web-platform-dx/web-features/blob/main/groups/transforms.yml

@jamesnw
Copy link
Collaborator

jamesnw commented Oct 9, 2024

James is better for review of feature composition here, but early feedback on the group is that should remove -css and instead make this a child of the css group, see example: https://github.com/web-platform-dx/web-features/blob/main/groups/transforms.yml

I agree on making this a child of the css group.

I think we can remove -css from the filename/id, but keep the (CSS) in the name. There's more discussion on #1771 (comment) about distinguishing the methods of making things move.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to land with a rename from transitions-css.yml to transitions.yml (and the refresh based on that)

Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jamesnw jamesnw dismissed autonome’s stale review October 15, 2024 15:49

Requested changes have been incorporated

@jamesnw jamesnw merged commit 9a62225 into web-platform-dx:main Oct 15, 2024
3 checks passed
@jamesnw jamesnw deleted the css-transitions-2 branch October 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants