Update MathML feature #1950
Merged
Update MathML feature #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
jamesnw
previously approved these changes
Oct 11, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
This looks good to me, and I agree the CSS properties belong here.
Collaborator
|
After approval, I realized that the draft spec has a lot of keys that were removed, but not added to the feature, for instance |
Collaborator
Author
|
hm, as I see it |
jamesnw
approved these changes
Oct 14, 2024
Collaborator
jamesnw
left a comment
jamesnw
left a comment
There was a problem hiding this comment.
Whoops- not sure what I was looking at where those were missing- sorry! Looks good!
ddbeck
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1940
I should have checked the draft folder and also search for "math" in BCD keys. Did that now.