Skip to content

Conversation

@jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Oct 11, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 11, 2024
Copy link
Contributor

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions

@@ -0,0 +1,18 @@
name: Bidirectional override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title seems ambiguous, maybe should include some combo of Unicode or layout or direction or something like that, which would disambiguate from people thinking it's the bdo tag (separate but related feature).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I renamed "Layout direction override"

@@ -0,0 +1,18 @@
name: Bidirectional override
description: The `unicode-bidi` and `direction` CSS properties override the Unicode layout algorithm in non-HTML documents. Authors should use the `dir` global HTML attribute instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in non-HTML documents" doesn't seem right? Do they only apply in that case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are applied in HTML documents, but use is discouraged. Stylesheets could be disabled, so text direction should be set in the HTML and not in CSS. I updated the description to clarify.

@jamesnw jamesnw requested a review from autonome October 21, 2024 14:03
@@ -0,0 +1,17 @@
name: Layout direction override
description: The `unicode-bidi` and `direction` CSS properties override the Unicode layout algorithm. For HTML documents, authors should use the `dir` global HTML attribute and `<bdo>` HTML element instead.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written, this sounds like an anti-feature. Is it possible you could link to some history about this feature? I'm wondering who it's for, if it's not deprecated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point- I'm not seeing historical posts about this, but both MDN and WebReference say it is explicitly for DTD designers, so I updated the description.

@jamesnw jamesnw requested a review from ddbeck October 21, 2024 14:48
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional description suggestions for you. In any case, ready to go. Thank you!

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@jamesnw jamesnw enabled auto-merge (squash) October 22, 2024 13:44
@jamesnw jamesnw merged commit f02b0d8 into web-platform-dx:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants