-
Notifications
You must be signed in to change notification settings - Fork 199
Add bidirectional-override #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
autonome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions
features/bidirectional-override.yml
Outdated
| @@ -0,0 +1,18 @@ | |||
| name: Bidirectional override | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title seems ambiguous, maybe should include some combo of Unicode or layout or direction or something like that, which would disambiguate from people thinking it's the bdo tag (separate but related feature).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I renamed "Layout direction override"
features/bidirectional-override.yml
Outdated
| @@ -0,0 +1,18 @@ | |||
| name: Bidirectional override | |||
| description: The `unicode-bidi` and `direction` CSS properties override the Unicode layout algorithm in non-HTML documents. Authors should use the `dir` global HTML attribute instead. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"in non-HTML documents" doesn't seem right? Do they only apply in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are applied in HTML documents, but use is discouraged. Stylesheets could be disabled, so text direction should be set in the HTML and not in CSS. I updated the description to clarify.
…idirectional-override
…idirectional-override
| @@ -0,0 +1,17 @@ | |||
| name: Layout direction override | |||
| description: The `unicode-bidi` and `direction` CSS properties override the Unicode layout algorithm. For HTML documents, authors should use the `dir` global HTML attribute and `<bdo>` HTML element instead. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, this sounds like an anti-feature. Is it possible you could link to some history about this feature? I'm wondering who it's for, if it's not deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point- I'm not seeing historical posts about this, but both MDN and WebReference say it is explicitly for DTD designers, so I updated the description.
ddbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional description suggestions for you. In any case, ready to go. Thank you!
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
No description provided.